implement drop temporary table ... and display temporary in show create table statements
#2824
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zachmu
reviewed
Jan 22, 2025
Member
zachmu
left a comment
zachmu
left a comment
There was a problem hiding this comment.
Actually one comment here: need a couple engine tests for this behavior:
- DROP TEMPORARY TABLE when there's a durable table with the same name (durable table should still be there)
- DROP TEMPORARY TABLE when there's only a durable table exists with that name (should error)
added 2 commits
January 22, 2025 15:03
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In-memory database doesn't support temporary tables, so tests are here: dolthub/dolt#8781
fixes: dolthub/dolt#7992